liurenjie1024 commented on issue #1560: URL: https://github.com/apache/iceberg-rust/issues/1560#issuecomment-3143970409
Hi, @CTTY Thanks for raising this issue. Instead of using `field.name` to match field, I would propose to change [`ArrowArrayAccessor`](https://github.com/apache/iceberg-rust/blob/cfe2a980b27cda744fab8e78b4550b167b4d4d45/crates/iceberg/src/arrow/value.rs#L429) to accept an `ArrowSchema`, which is converted from `ParquetWriter` 's schema. And `ArrowArrayAccessor` should use passed in `ArrowSchema` to match. The motivation behind this is that the array schema is passed by user, and it's not quite friendly to ask user to match their name, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
