liurenjie1024 commented on code in PR #1570:
URL: https://github.com/apache/iceberg-rust/pull/1570#discussion_r2246924272
##########
crates/integrations/datafusion/src/physical_plan/scan.rs:
##########
@@ -79,6 +79,22 @@ impl IcebergTableScan {
}
}
+ pub fn table(&self) -> &Table {
+ &self.table
+ }
+
+ pub fn snapshot_id(&self) -> Option<i64> {
+ self.snapshot_id
+ }
+
+ pub fn projection(&self) -> Option<Vec<String>> {
Review Comment:
Same as following.
##########
crates/integrations/datafusion/src/physical_plan/scan.rs:
##########
@@ -79,6 +79,22 @@ impl IcebergTableScan {
}
}
+ pub fn table(&self) -> &Table {
+ &self.table
+ }
+
+ pub fn snapshot_id(&self) -> Option<i64> {
+ self.snapshot_id
+ }
+
+ pub fn projection(&self) -> Option<Vec<String>> {
+ self.projection.clone()
+ }
+
+ pub fn predicate(&self) -> Option<Predicate> {
Review Comment:
```suggestion
pub fn predicate(&self) -> Option<&Predicate> {
```
I prefer to return a reference only and leave it to user to clone if
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
