Fokko commented on code in PR #2265: URL: https://github.com/apache/iceberg-python/pull/2265#discussion_r2246204103
########## tests/conftest.py: ########## @@ -1858,15 +1861,38 @@ def simple_map() -> MapType: @pytest.fixture(scope="session") -def generated_manifest_entry_file(avro_schema_manifest_entry: Dict[str, Any]) -> Generator[str, None, None]: +def test_schema() -> Schema: + return Schema(NestedField(1, "VendorID", IntegerType(), False), NestedField(2, "tpep_pickup_datetime", IntegerType(), False)) + + [email protected](scope="session") +def test_partition_spec() -> Schema: + return PartitionSpec( + PartitionField(1, 1000, IdentityTransform(), "VendorID"), + PartitionField(2, 1001, DayTransform(), "tpep_pickup_datetime"), Review Comment: Refactored this out into a fixture and changed this to a `DayTransform` to match it with the Avro schema: https://github.com/apache/iceberg-python/blob/904c0b77c33768716e8672b38bae73bfcf565fbf/tests/conftest.py#L1674-L1679 ########## pyiceberg/manifest.py: ########## @@ -1279,6 +1279,7 @@ def __init__( "parent-snapshot-id": str(parent_snapshot_id) if parent_snapshot_id is not None else "null", "sequence-number": str(sequence_number), "format-version": "2", + "content": "data", Review Comment: This header is missing, and should be set to `data` until we support MoR deletes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
