danielcweeks commented on code in PR #13710:
URL: https://github.com/apache/iceberg/pull/13710#discussion_r2245804479
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -707,7 +707,8 @@ protected String defaultWarehouseLocation(TableIdentifier
tableIdentifier) {
clients.run(client ->
client.getDatabase(tableIdentifier.namespace().levels()[0]));
if (databaseData.getLocationUri() != null) {
Review Comment:
You might want to change this to `Strings.isNullOrEmpty` otherwise you have
a mismatch between this check and the one performed by
`LocationUtil::stripTriailingSlash`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
