amogh-jahagirdar commented on code in PR #13697:
URL: https://github.com/apache/iceberg/pull/13697#discussion_r2245584888
##########
core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java:
##########
@@ -779,6 +779,22 @@ public void testAddRequiredColumnCaseInsensitive() {
.hasMessage("Cannot add column, name already exists: ID");
}
+ @Test
Review Comment:
I see, we already had an additional incremental validation in
`internalAddColumn` which was catching the case where a duplicate field is
added to a schema already containing that field in a case-insensitive way.
Cool, no need to duplicate the same test then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
