dramaticlly commented on code in PR #13645:
URL: https://github.com/apache/iceberg/pull/13645#discussion_r2241129065
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2DistributionMode.java:
##########
@@ -556,7 +556,7 @@ public void testRangeDistributionStatisticsMigration()
throws Exception {
// sometimes
assertThat(addedDataFiles).hasSize(writeParallelism);
// verify there is no overlap in min-max stats range
- if (writeParallelism > 1) {
+ if (writeParallelism > 2) {
Review Comment:
Generally speaking, if there's unrelated but flaky test, maintainer can help
rerun the test to pass the CI, or a separate PR to fix the problem. From what i
can tell, this test is configured with [writeParallelism to either 1 or
2](https://github.com/apache/iceberg/blob/2698cf0c10101b860b9547fdaee10bde85c4341e/flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2DistributionMode.java#L93-L109),
so change if condition to > 2 means skip the test entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
