liurenjie1024 commented on code in PR #1553: URL: https://github.com/apache/iceberg-rust/pull/1553#discussion_r2239081457
########## CONTRIBUTING.md: ########## @@ -105,7 +105,7 @@ Currently, iceberg-rust uses Docker to set up environment for integration tests. For MacOS users, you can install [OrbStack as a docker alternative](docs/contributing/orbstack.md). -For podman, refer to [Using Podman instead of Docker](docs/contributing/podman.md) +For Linux users Podman is recommended, refer to [Using Podman instead of Docker](docs/contributing/podman.md) Review Comment: I'm hesitating to add this change. I think on linux both podman and docker are equal important, and in fact our ci is using docker on linux. ########## docs/contributing/podman.md: ########## @@ -19,24 +19,30 @@ # Using Podman instead of Docker -Iceberg-rust does not require containerization, except for integration tests, where "docker" and "docker-compose" are used to start containers for minio and various catalogs. Below instructions setup "rootful podman" and docker's official docker-compose plugin to run integration tests as an alternative to docker or Orbstack. +Iceberg-rust does not require containerization, except for integration tests, where "docker" and "docker-compose" are used to start containers for minio and various catalogs. Below instructions setup "rootful podman" and docker's official docker-compose plugin to run integration tests as an alternative to docker or Orbstack. It is recommended to setup Podman if you are developing in a Linux or WSL environment. Review Comment: I don't think we should add this statement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
