mxm commented on code in PR #13662:
URL: https://github.com/apache/iceberg/pull/13662#discussion_r2238876559
##########
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicWriter.java:
##########
@@ -180,4 +236,19 @@ private static int getNumDataFiles(Table table) {
}
return 0;
}
+
+ private Map<String, String> properties(DynamicWriter dynamicWriter) {
+ DynFields.BoundField<Map<WriteTarget, TaskWriter<RowData>>> writerField =
+ DynFields.builder().hiddenImpl(dynamicWriter.getClass(),
"writers").build(dynamicWriter);
+
+ DynFields.BoundField<FlinkAppenderFactory> appenderField =
+ DynFields.builder()
+ .hiddenImpl(BaseTaskWriter.class, "appenderFactory")
+ .build(writerField.get().values().iterator().next());
+ DynFields.BoundField<Map<String, String>> propsField =
+ DynFields.builder()
+ .hiddenImpl(FlinkAppenderFactory.class, "props")
+ .build(appenderField.get());
+ return propsField.get();
+ }
Review Comment:
You are right, we can't fully test the overrides without peeking into the
writers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
