mxm commented on code in PR #13669:
URL: https://github.com/apache/iceberg/pull/13669#discussion_r2238834613
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestRewriteDataFiles.java:
##########
@@ -373,6 +374,45 @@ void testV2Table() throws Exception {
.build());
}
+ @Test
+ void testRewriteUnPartitionedWithFilter() throws Exception {
+ Table table = createTable();
+ insert(table, 1, "a");
+ insert(table, 2, "b");
+ insert(table, 3, "c");
+ insert(table, 4, "d");
+
+ assertFileNum(table, 4, 0);
+
+ appendRewriteDataFiles(
+ RewriteDataFiles.builder()
+ .parallelism(2)
+ .deleteFileThreshold(10)
+ .targetFileSizeBytes(1_000_000L)
+ .maxFileGroupSizeBytes(10_000_000L)
+ .maxFileSizeBytes(2_000_000L)
+ .minFileSizeBytes(500_000L)
+ .minInputFiles(2)
+ .filter(Expressions.in("id", 1, 2))
Review Comment:
It's always nice to add a comment at the test-relevant parameters (here: the
filter).
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/maintenance/api/TestRewriteDataFiles.java:
##########
@@ -373,6 +374,45 @@ void testV2Table() throws Exception {
.build());
}
+ @Test
+ void testRewriteUnPartitionedWithFilter() throws Exception {
Review Comment:
Is "Unpartitioned" relevant for this test? If not, we could rename the test
to `testRewriteWithFilter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
