ZENOTME commented on issue #1382: URL: https://github.com/apache/iceberg-rust/issues/1382#issuecomment-3130488558
> If you haven't started, could I start working on the Implement `fanout partitioned data writer` as I see rolling file writer is in progress. Hi @stevie9868, actually there is work for partition writer here: https://github.com/apache/iceberg-rust/issues/342. And I have a PR for first part: https://github.com/apache/iceberg-rust/pull/1040. Feel free to complete it next when the first PR have been merged. > For the first step, I am going to introduce two traits one for PartitionFileWriter and PartitionFileWriterBuilder similar to FileWriter and FileWriterBuilder. And actually we don't need the new trait. We can just let partition writer implement the iceberg writer trait and other writer can built on it like following in ``` let data_file_builder = ... let partition_writer_builder = PartitionWriterBuilder::new(data_file_builder) ``` I think this idea is what @CTTY mentioned that "PartitionFileWriter can just be a decorator just like RollingFileWriter, and don't need to be a trait. " -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
