aihuaxu commented on code in PR #13692:
URL: https://github.com/apache/iceberg/pull/13692#discussion_r2237662138
##########
api/src/test/java/org/apache/iceberg/variants/TestSerializedPrimitives.java:
##########
@@ -208,17 +208,17 @@ public void testDecimal8() {
primitiveHeader(9),
0x09, // scale=9
(byte) 0xB1,
- 0x1C,
- 0x6C,
- (byte) 0xB1,
- (byte) 0xF4,
- 0x10,
- 0x22,
- 0x11
+ (byte) 0xFA,
Review Comment:
Basically, I'm using the right decimal4 and decimal8 values for testing.
`(byte) 0xD2, 0x02, (byte) 0x96, 0x49 ` has value 1234567890 but it should
be decimal8 instead of decimal4.
Maybe I should add a check to error out if it's out of the decimal4 range?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
