geruh opened a new pull request, #13666: URL: https://github.com/apache/iceberg/pull/13666
The BaseDVFileWriter was creating Puffin files in its `close()` method, even when no delete operations were performed. Resulting in empty orphaned Puffin files being created and `DeleteWriteResult` is empty. It seems by [design](https://github.com/apache/iceberg/blob/dd70b7e8f7c9c948b197e0799903928db5efe9c4/core/src/test/java/org/apache/iceberg/puffin/TestPuffinWriter.java#L70) that the puffin writer always creates an output stream even if no rows are written. ### Repro steps 1. Create MOR V3 Table with and insert some rows i.e. `INSERT INTO test_table VALUES (10, 'a'), (20, 'b'), (30, 'c');` 2. Delete from table where a positional scan is not null but no rows match i.e. `DELETE FROM test_table WHERE id = 25;` 3. Observe empty puffin files in data directory not referenced by any manifest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
