mxm commented on code in PR #13640:
URL: https://github.com/apache/iceberg/pull/13640#discussion_r2227886803
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestEvolveSchemaVisitor.java:
##########
@@ -463,7 +464,7 @@ public void testReplaceListWithPrimitive() {
assertThatThrownBy(
() ->
EvolveSchemaVisitor.visit(
- loadUpdateApi(currentSchema, 3), currentSchema,
targetSchema))
+ loadUpdateApi(currentSchema), currentSchema, targetSchema))
Review Comment:
Yes, good attention to detail. The refactoring is precisely to prevent
setting the wrong id. `3` wasn't wrong, but it could have been `2` as well (the
max current field id). At runtime, SchemaUpdate will set this id automatically,
but we are using the test constructor here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
