lliangyu-lin commented on code in PR #493: URL: https://github.com/apache/iceberg-go/pull/493#discussion_r2223979653
########## table/transaction_test.go: ########## @@ -114,21 +137,143 @@ func (s *SparkIntegrationTestSuite) TestAddFile() { tbl, err = tx.Commit(s.ctx) s.Require().NoError(err) - spark, err := s.stack.ServiceContainer(s.T().Context(), "spark-iceberg") + err = recipe.ExecuteSpark(s.T(), "./validation.py", "--test", "TestAddedFile") + s.Require().NoError(err) +} + +func (s *SparkIntegrationTestSuite) TestDifferentDataTypes() { + icebergSchema := iceberg.NewSchema(0, + iceberg.NestedField{ID: 1, Name: "bool", Type: iceberg.PrimitiveTypes.Bool}, + iceberg.NestedField{ID: 2, Name: "string", Type: iceberg.PrimitiveTypes.String}, + iceberg.NestedField{ID: 3, Name: "string_long", Type: iceberg.PrimitiveTypes.String}, + iceberg.NestedField{ID: 4, Name: "int", Type: iceberg.PrimitiveTypes.Int32}, + iceberg.NestedField{ID: 5, Name: "long", Type: iceberg.PrimitiveTypes.Int64}, + iceberg.NestedField{ID: 6, Name: "float", Type: iceberg.PrimitiveTypes.Float32}, + iceberg.NestedField{ID: 7, Name: "double", Type: iceberg.PrimitiveTypes.Float64}, + iceberg.NestedField{ID: 8, Name: "timestamp", Type: iceberg.PrimitiveTypes.Timestamp}, + iceberg.NestedField{ID: 9, Name: "timestamptz", Type: iceberg.PrimitiveTypes.TimestampTz}, + iceberg.NestedField{ID: 10, Name: "date", Type: iceberg.PrimitiveTypes.Date}, + iceberg.NestedField{ID: 11, Name: "uuid", Type: iceberg.PrimitiveTypes.UUID}, + iceberg.NestedField{ID: 12, Name: "binary", Type: iceberg.PrimitiveTypes.Binary}, + iceberg.NestedField{ID: 13, Name: "fixed", Type: iceberg.FixedTypeOf(16)}, + iceberg.NestedField{ID: 14, Name: "small_dec", Type: iceberg.DecimalTypeOf(8, 2)}, + iceberg.NestedField{ID: 15, Name: "med_dec", Type: iceberg.DecimalTypeOf(16, 2)}, + iceberg.NestedField{ID: 16, Name: "large_dec", Type: iceberg.DecimalTypeOf(24, 2)}, + iceberg.NestedField{ID: 17, Name: "list", Type: &iceberg.ListType{ Review Comment: Was planning to test more complexed schema with other complex data types, but is getting issues in arrow to iceberg schema visitor when AppendTable with struct or map. I'm planning to add those tests later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org