amogh-jahagirdar commented on code in PR #13391:
URL: https://github.com/apache/iceberg/pull/13391#discussion_r2220341355
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java:
##########
@@ -648,16 +675,15 @@ private void setNulls(
}
private void setNextNValuesInVector(
- int typeWidth,
NullabilityHolder nullabilityHolder,
VectorizedValuesReader valuesReader,
int bufferIdx,
FieldVector vector,
- int numValues) {
+ int numValues,
+ NumericBaseReader reader) {
Review Comment:
Minor since this is private, but should we just make
`setNextNValuesInVector` a private member of `NumericBaseReader`. It looks like
this would only apply for that particular reader, and then we can remove
passing `this` in NumericBaseReader to this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
