zeroshade commented on code in PR #491:
URL: https://github.com/apache/iceberg-go/pull/491#discussion_r2219939538
##########
table/updates.go:
##########
@@ -452,7 +458,7 @@ type removeSnapshotRefUpdate struct {
// NewRemoveSnapshotRefUpdate creates a new update that removes a snapshot
reference
// from the table metadata.
-func NewRemoveSnapshotRefUpdate(ref string) *removeSnapshotRefUpdate {
+func NewRemoveSnapshotRefUpdate(ref string) Update {
Review Comment:
Go convention, where possible, is to return the concrete type, not the
interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
