ajantha-bhat commented on code in PR #13561:
URL: https://github.com/apache/iceberg/pull/13561#discussion_r2209219898
##########
kafka-connect/build.gradle:
##########
@@ -64,9 +64,14 @@
project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
configurations {
hive {
extendsFrom runtimeClasspath
+ // force upgrades for dependencies with known vulnerabilities...
+ resolutionStrategy {
+ force 'commons-beanutils:commons-beanutils:1.11.0'
+ }
}
all {
exclude group: 'javax.activation', module: 'activation'
+ exclude group: 'commons-beanutils'
Review Comment:
The (compile) checkstyle fails because of this line. Do we really need to
exclude it?
> When we add exclude group: 'commons-beanutils' to our configurations.all
block, we are instructing Gradle to prevent any version of commons-beanutils
from being included in any configuration's classpath for that project. This
includes the classpath that Gradle sets up for its own plugins, like the
Checkstyle plugin.
##########
kafka-connect/build.gradle:
##########
@@ -64,9 +64,14 @@
project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
configurations {
hive {
extendsFrom runtimeClasspath
+ // force upgrades for dependencies with known vulnerabilities...
+ resolutionStrategy {
+ force 'commons-beanutils:commons-beanutils:1.11.0'
+ }
}
all {
exclude group: 'javax.activation', module: 'activation'
+ exclude group: 'commons-beanutils'
Review Comment:
The (compile) checkstyle fails because of this line. Do we really need to
exclude it?
When we add exclude group: 'commons-beanutils' to our configurations.all
block, we are instructing Gradle to prevent any version of commons-beanutils
from being included in any configuration's classpath for that project. This
includes the classpath that Gradle sets up for its own plugins, like the
Checkstyle plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
