amogh-jahagirdar commented on code in PR #13505: URL: https://github.com/apache/iceberg/pull/13505#discussion_r2208550568
########## open-api/rest-catalog-open-api.py: ########## @@ -1147,7 +1147,7 @@ class NotExpression(BaseModel): class TableMetadata(BaseModel): - format_version: int = Field(..., alias='format-version', ge=1, le=2) + format_version: int = Field(..., alias='format-version', ge=1, le=4) Review Comment: I'd say this should just be 3 and not 4. My mental model for this is that the REST protocol change here depends on which table format versions are ratified by the community. I don't think we should express that it's possible for a REST server to handle V4 tables because that format version hasn't been established yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
