mapleFU commented on code in PR #145:
URL: https://github.com/apache/iceberg-cpp/pull/145#discussion_r2207630509
##########
src/iceberg/type.cc:
##########
@@ -28,6 +28,16 @@
namespace iceberg {
+namespace {
+bool StringEqualsCaseInsensitive(std::string_view lhs, std::string_view rhs) {
+ if (lhs.size() != rhs.size()) {
+ return false;
+ }
+ return std::equal(lhs.begin(), lhs.end(), rhs.begin(),
+ [](char a, char b) { return std::tolower(a) ==
std::tolower(b); });
+}
Review Comment:
the bad thing is that this could only uses ascii, I suggest import icu or
utf8 libs ( or even boost::locale?) for this scenerio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
