zhjwpku commented on code in PR #132:
URL: https://github.com/apache/iceberg-cpp/pull/132#discussion_r2207162468
##########
src/iceberg/transform_function.cc:
##########
@@ -48,7 +48,27 @@ Result<ArrowArray> BucketTransform::Transform(const
ArrowArray& input) {
}
Result<std::shared_ptr<Type>> BucketTransform::ResultType() const {
- return NotImplemented("BucketTransform::result_type");
+ auto src_type = source_type();
+ if (!src_type) {
+ return NotSupported("null is not a valid input type for bucket transform");
Review Comment:
I'm not sure, the `Transform::Bind` doesn't check the `source_type`, so it
seems possible that `TransformFunction` can has a nullptr as it's source type.
Should we error out in `Transform::Bind`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
