kevinjqliu commented on code in PR #2206:
URL: https://github.com/apache/iceberg-python/pull/2206#discussion_r2206258792


##########
pyiceberg/catalog/hive.py:
##########
@@ -389,8 +389,8 @@ def _create_hive_table(self, open_client: Client, 
hive_table: HiveTable) -> None
 
     def _get_hive_table(self, open_client: Client, database_name: str, 
table_name: str) -> HiveTable:
         try:
-            return open_client.get_table(dbname=database_name, 
tbl_name=table_name)
-        except NoSuchObjectException as e:
+            return open_client.get_tables(db_name=database_name, 
pattern=table_name).pop()

Review Comment:
   It looks like `get_tables` is available in previous versions of thrift 
clients 
   
   i see
   ```
       def get_tables(self, db_name, pattern):
           """
           Parameters:
            - db_name
            - pattern
   
           """
           self.send_get_tables(db_name, pattern)
           return self.recv_get_tables()
   ```
   in `vendor/hive_metastore/ThriftHiveMetastore.py`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to