kevinjqliu commented on PR #2178: URL: https://github.com/apache/iceberg-python/pull/2178#issuecomment-3071741466
Thanks for the thoughtful explanation @jayceslesar I prefer option 1 too. We're making the intent of `**self.__dict__` more explicit by only using the parameters of `__init__`. Option 2 introduces some maintenance burden; we'd have to remember updating `_arguments` whenever a new param is added to `__init__`. As you pointed out, option 3 requires subclasses to follow the same signature. It might be bypassed by subclasses if `**kwargs` is not specified Option 4 is interesting. [Pydantic's model_dump by default ignored property](https://docs.pydantic.dev/latest/concepts/serialization/#modelmodel_dump) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
