danielcweeks commented on code in PR #13507:
URL: https://github.com/apache/iceberg/pull/13507#discussion_r2196213424


##########
core/src/main/java/org/apache/iceberg/rest/RESTMetricsReporter.java:
##########
@@ -51,15 +56,30 @@ public void report(MetricsReport report) {
       return;
     }
 
+    executor.submit(() -> {

Review Comment:
   I would suggest that we use `Tasks` utility class here.  I believe the rest 
client will handle a number of retry scenarios, so I don't know how much we 
want to do retries at this layer.  @nastra might have thoughts on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to