Re: [PR] Enforce that test classes start with "Test" instead of suffix [iceberg]

[via GitHub]

CuteChuanChuan commented on PR #13466:
URL: https://github.com/apache/iceberg/pull/13466#issuecomment-3053087117

   Hi @nastra ,
   
   Thanks for your review! I've addressed all the feedback points:
   
   ✅ Added suppression rule to limit TestClassNamingConvention to test 
directories only
   ✅ Renamed abstract base classes to use *TestBase suffix pattern 
(DataTestBase, RecordWrapperTestBase, AvroDataTestBase)
   ✅ Updated all references and imports in extending classes
   
   Appendix:
   - Script to test that checkstyle is only applied to test directories:
   ```
   #!/bin/bash
   
   # Test Case 1: Should be ignored
   cat > core/src/main/java/org/apache/iceberg/SomethingTest.java << 'EOF'
   package org.apache.iceberg;
   
   public class SomethingTest {
       // This should be ignored by TestClassNamingConvention (in main 
directory)
   }
   EOF
   
   # Test Case 2: Should be checked
   cat > core/src/test/java/org/apache/iceberg/AnotherBadTest.java << 'EOF'
   package org.apache.iceberg;
   
   public class AnotherBadTest {
       // This should trigger TestClassNamingConvention violation (in test 
directory)
   }
   EOF
   
   # Run checkstyle
   ./gradlew :iceberg-core:checkstyleMain
   ./gradlew :iceberg-core:checkstyleTest
   
   # Clean up
   rm -f core/src/main/java/org/apache/iceberg/SomethingTest.java
   rm -f core/src/test/java/org/apache/iceberg/AnotherBadTest.java
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org