zeroshade commented on code in PR #459:
URL: https://github.com/apache/iceberg-go/pull/459#discussion_r2193568773
##########
config/config_test.go:
##########
@@ -78,6 +78,27 @@ catalog:
Warehouse: "catalog_name",
},
},
+ // catalog with rest-config
+ {
+ []byte(`
+catalog:
+ rest-catalog:
+ type: rest
+ uri: https://glue.us-east-1.amazonaws.com/iceberg
+ output: json
+ credential: client-id:client-secret
+ warehouse: 123456789012
+ rest-config:
auth-url=https://auth.example.com,sigv4-enabled=true,sigv4-region=us-east-1,sigv4-service=glue,tls-skip-verify=false
Review Comment:
I'm confused, why don't we just use the existing properties for these that
we already recognize as separate properties to pass?
i.e. `rest.sigv4-enabled`, `rest.signing-region`, `rest.authorization-url`,
etc.. (see `catalog/rest.go`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
