zeroshade commented on code in PR #480:
URL: https://github.com/apache/iceberg-go/pull/480#discussion_r2193079278
##########
catalog/glue/glue.go:
##########
@@ -694,7 +695,7 @@ func (c *Catalog) getTable(ctx context.Context, database,
tableName string) (*ty
return nil, fmt.Errorf("failed to get table %s.%s: %w",
database, tableName, err)
}
- if tblRes.Table.Parameters[tableTypePropsKey] != glueTypeIceberg {
+ if strings.ToUpper(tblRes.Table.Parameters[tableTypePropsKey]) !=
glueTypeIceberg {
Review Comment:
any particular reason to use `ToUpper` here and `EqualFold` below instead of
just using `EqualFold` in both cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
