RussellSpitzer commented on code in PR #13284:
URL: https://github.com/apache/iceberg/pull/13284#discussion_r2193056673
##########
api/src/test/java/org/apache/iceberg/variants/TestSerializedObject.java:
##########
@@ -257,13 +246,39 @@ public void testLargeObject(boolean sortFieldNames) {
assertThat(object.type()).isEqualTo(PhysicalType.OBJECT);
assertThat(object.numFields()).isEqualTo(10_000);
- for (Map.Entry<String, SerializedPrimitive> entry : fields.entrySet()) {
+ for (Map.Entry<String, VariantPrimitive<?>> entry : fields.entrySet()) {
VariantValue fieldValue = object.get(entry.getKey());
- assertThat(fieldValue.type()).isEqualTo(PhysicalType.STRING);
-
assertThat(fieldValue.asPrimitive().get()).isEqualTo(entry.getValue().get());
+ VariantTestUtil.assertVariantString(fieldValue,
entry.getValue().get().toString());
}
}
+ @Test
+ public void testShortStringsInVariantPrimitives() {
Review Comment:
(Although spotless is probably going to dislike your spacing on @Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
