zhjwpku commented on PR #139: URL: https://github.com/apache/iceberg-cpp/pull/139#issuecomment-3049169581
> So should `Result<>` be removed after this is introduced? Personally I think Result/Status are well-structured wrappers, but I'm glad to hear others' opinions. > > Besides, C++23 has resize_and_overwrite, allowing zero-cost buffer initialization Ah, I wasn't aware of this feature, could you suggest where it might be applied? I think we can adopt more C++23 features in future PRs, assuming compiler support. I tried using `views::join_with` to replace `JoinByDot`, but it's only supported starting from Clang 21 (see [1]), so I gave it up. [1] https://libcxx.llvm.org/Status/Cxx23.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
