stevenzwu commented on code in PR #13189:
URL: https://github.com/apache/iceberg/pull/13189#discussion_r2191089719


##########
format/spec.md:
##########
@@ -101,10 +101,10 @@ Inheriting the sequence number from manifest metadata 
allows writing a new manif
 
 Row-level deletes are stored in delete files.
 
-There are two ways to encode a row-level delete:
-
-* [_Position deletes_](#position-delete-files) mark a row deleted by data file 
path and the row position in the data file

Review Comment:
   earlier, I was thinking about changing the `Delete Format` section. 
   ```
   ### Row-level Deletes
   #### Position Deletes
   Deletion Vectors -- moved under new section Position Deletes
   Position Delete Files -- moved under new section Position Deletes
   #### Equality Delete
   #### Delete File Stats
   ```
   
   But we can go with the approach in this PR by just clarifying the overview 
section. Also add an one-sentence fix in the delete format section
   ```
   There are three types of row-level deletes:
   -->
   There are three file formats for encoding row-level delete:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to