nastra commented on code in PR #12743:
URL: https://github.com/apache/iceberg/pull/12743#discussion_r2182454505
##########
core/src/test/java/org/apache/iceberg/TestClientPoolImpl.java:
##########
@@ -84,6 +141,18 @@ static class RetryableException extends RuntimeException {}
static class NonRetryableException extends RuntimeException {}
+ static class ImplementationSpecificException extends NonRetryableException {
Review Comment:
```suggestion
static class CustomException extends NonRetryableException {
```
this reads shorter and also reduces test method name lengths. Can you please
also rename the test methods to reflect that naming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
