mwa28 commented on issue #2138: URL: https://github.com/apache/iceberg-python/issues/2138#issuecomment-3023843384
Sorry i haven't had the time to look at this yet, kinda hard to build an non-release version for my lambda at the moment, need some time to test it. I like the idea of adding the partition_key to the join_keys by default but i think this should be an intrinsic operation rather than giving the user the ability to override the value if set by default and then having to ask them to keep the partition column in the join keys. I think your modification could be onto something, i will keep you posted once i have the time to try it myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
