mxm commented on code in PR #13394: URL: https://github.com/apache/iceberg/pull/13394#discussion_r2177140487
########## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java: ########## @@ -191,16 +187,11 @@ public static class Builder<T> { Builder() {} - public Builder<T> forInput(DataStream<T> inputStream) { + public Builder forInput(DataStream<DynamicRecord> inputStream) { Review Comment: Printing this message excessively may also cause performance issues. >I guess this is because schemas are copied across stages. Yes, chaining will always copy, unless object reuse is enabled. >We may indeed need a custom serialiser to fix this or leave things as status quo. A custom serializer per se wouldn't prevent this, unless it returned always the same schema object for when the schema doesn't change. The problem is that we don't have a cheap way to compare two schema objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org