liurenjie1024 commented on code in PR #1480: URL: https://github.com/apache/iceberg-rust/pull/1480#discussion_r2177027195
########## crates/iceberg/src/lib.rs: ########## @@ -22,12 +22,10 @@ //! ## Scan A Table //! //! ```rust, ignore Review Comment: It's supposed to be able to compile now? ########## crates/iceberg/src/catalog/mod.rs: ########## @@ -17,6 +17,8 @@ //! Catalog API for Apache Iceberg +pub mod memory; Review Comment: This is odd to me, user have to use `iceberg::memory::MemoryCatalog`. I would prefer to ask user to use `iceberg::MemoryCatalog`, `iceberg::catalog::memory::MeoryCatalog`, or `iceberg::catalog::MemoryCatalog` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
