kevinjqliu commented on code in PR #2029:
URL: https://github.com/apache/iceberg-python/pull/2029#discussion_r2173819438
##########
pyiceberg/expressions/visitors.py:
##########
@@ -900,6 +906,24 @@ def visit_bound_predicate(self, predicate:
BoundPredicate[L]) -> BooleanExpressi
# in the file schema when reading older data
if isinstance(predicate, BoundIsNull):
return AlwaysTrue()
+ # Evaluate projected field by value extracted from partition
+ elif (field_name := predicate.term.ref().field.name) in
self.projected_missing_fields:
Review Comment:
nit: it feels like we're "shoving" this feature into `_ColumnNameTranslator`
and its now doing 2 jobs.
these fields are coming from the partition, is there a way to evaluate the
predicates at the partition level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
