CTTY commented on code in PR #1359: URL: https://github.com/apache/iceberg-rust/pull/1359#discussion_r2167850949
########## crates/iceberg/src/transaction/update_statistics.rs: ########## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::HashMap; +use std::sync::Arc; + +use async_trait::async_trait; + +use crate::spec::StatisticsFile; +use crate::table::Table; +use crate::transaction::{ActionCommit, TransactionAction}; +use crate::{Result, TableUpdate}; + +/// A transactional action for updating statistics files in a table +pub struct UpdateStatisticsAction { + statistics_to_set: HashMap<i64, Option<StatisticsFile>>, +} + +impl UpdateStatisticsAction { + pub fn new() -> Self { + Self { + statistics_to_set: HashMap::default(), + } + } + + /// Set the table's statistics file for given snapshot, replacing the previous statistics file for + /// the snapshot if any exists. The snapshot id of the statistics file will be used. + /// + /// # Arguments + /// + /// * `statistics_file` - The [`StatisticsFile`] to associate with its corresponding snapshot ID. + /// + /// # Returns + /// + /// An updated [`UpdateStatisticsAction`] with the new statistics file applied. + pub fn set_statistics(mut self, statistics_file: StatisticsFile) -> Self { + self.statistics_to_set + .insert(statistics_file.snapshot_id, Some(statistics_file)); + self + } + + /// Remove the table's statistics file for given snapshot. + /// + /// # Arguments + /// + /// * `snapshot_id` - The ID of the snapshot whose statistics file should be removed. + /// + /// # Returns + /// + /// An updated [`UpdateStatisticsAction`] with the removal operation recorded. + pub fn remove_statistics(mut self, snapshot_id: i64) -> Self { + self.statistics_to_set.insert(snapshot_id, None); + self + } +} + +impl Default for UpdateStatisticsAction { + fn default() -> Self { + Self::new() + } +} + +#[async_trait] +impl TransactionAction for UpdateStatisticsAction { + async fn commit(self: Arc<Self>, _table: &Table) -> Result<ActionCommit> { + let mut updates: Vec<TableUpdate> = vec![]; + + self.statistics_to_set + .iter() + .for_each(|(snapshot_id, statistic_file)| { + if let Some(statistics) = statistic_file { + updates.push(TableUpdate::SetStatistics { + statistics: statistics.clone(), + }) + } else { + updates.push(TableUpdate::RemoveStatistics { + snapshot_id: *snapshot_id, + }) + } + }); + + Ok(ActionCommit::new(updates, vec![])) + } +} + +#[cfg(test)] +mod tests { + use std::collections::HashMap; + + use as_any::Downcast; + + use crate::spec::{BlobMetadata, StatisticsFile}; + use crate::transaction::tests::make_v2_table; + use crate::transaction::update_statistics::UpdateStatisticsAction; + use crate::transaction::{ApplyTransactionAction, Transaction}; + + #[test] + fn test_update_statistics() { Review Comment: Yes, I'm thinking the same, but I'm planning to create another issue to track this and other tx API tests improvement for others to ramp up, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
