nastra commented on code in PR #13245: URL: https://github.com/apache/iceberg/pull/13245#discussion_r2166008394
########## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: ########## @@ -172,14 +172,16 @@ public RewriteDataFiles.Result execute() { partialProgressEnabled ? doExecuteWithPartialProgress(plan, commitManager(startingSnapshotId)) : doExecute(plan, commitManager(startingSnapshotId)); + ImmutableRewriteDataFiles.Result result = resultBuilder.build(); if (removeDanglingDeletes) { RemoveDanglingDeletesSparkAction action = new RemoveDanglingDeletesSparkAction(spark(), table); int removedCount = Iterables.size(action.execute().removedDeleteFiles()); - resultBuilder.removedDeleteFilesCount(removedCount); + return result.withRemovedDeleteFilesCount(result.removedDeleteFilesCount() + removedCount); Review Comment: yes correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org