szehon-ho commented on code in PR #13106:
URL: https://github.com/apache/iceberg/pull/13106#discussion_r2164641700
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/RollbackToSnapshotProcedure.java:
##########
@@ -88,10 +98,15 @@ public InternalRow[] call(InternalRow args) {
table.manageSnapshots().rollbackTo(snapshotId).commit();
InternalRow outputRow =
newInternalRow(previousSnapshot.snapshotId(), snapshotId);
- return new InternalRow[] {outputRow};
+ return asIteratorScan(OUTPUT_TYPE, outputRow);
});
}
+ @Override
+ public String name() {
+ return NAME;
+ }
+
@Override
public String description() {
return "RollbackToSnapshotProcedure";
Review Comment:
we should probably improve the description, but can be done in separate pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
