liurenjie1024 commented on code in PR #1464:
URL: https://github.com/apache/iceberg-rust/pull/1464#discussion_r2163570242
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -313,6 +314,28 @@ impl TableCommit {
pub fn take_updates(&mut self) -> Vec<TableUpdate> {
take(&mut self.updates)
}
+
+ /// Applies this [`TableCommit`] to the given [`Table`] as part of a
catalog update.
+ /// Typically used by [`Catalog::update_table`] to validate requirements
and apply metadata updates.
+ ///
+ /// Returns a new [`Table`] with updated metadata,
+ /// or an error if validation or application fails.
+ #[allow(dead_code)]
Review Comment:
Why we need this? IIRC, a public api doesn't need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
