Guosmilesmile commented on code in PR #13302:
URL: https://github.com/apache/iceberg/pull/13302#discussion_r2167017129
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/AntiJoin.java:
##########
@@ -70,21 +75,30 @@ public void open(OpenContext openContext) throws Exception {
@Override
public void processElement1(String value, Context context, Collector<String>
collector)
throws Exception {
- foundInTable.add(value);
- context.timerService().registerEventTimeTimer(context.timestamp());
+ shouldSkipElement(value, context);
+ if (!foundInTable.contains(value)) {
+ foundInTable.put(value, true);
+ context.timerService().registerEventTimeTimer(context.timestamp());
+ }
}
@Override
public void processElement2(String value, Context context, Collector<String>
collector)
throws Exception {
+ shouldSkipElement(value, context);
foundInFileSystem.update(value);
context.timerService().registerEventTimeTimer(context.timestamp());
}
@Override
public void onTimer(long timestamp, OnTimerContext ctx, Collector<String>
out) throws Exception {
+ if (Boolean.TRUE.equals(hasUriError.value())) {
+ clearState();
+ return;
+ }
+
List<FileURI> foundInTablesList = Lists.newArrayList();
- for (String uri : foundInTable.get()) {
+ for (String uri : foundInTable.keys()) {
Review Comment:
Thanks for the suggestion, I have chaged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
