RussellSpitzer commented on code in PR #13386:
URL: https://github.com/apache/iceberg/pull/13386#discussion_r2166927269
##########
core/src/main/java/org/apache/iceberg/rest/BaseHTTPClient.java:
##########
@@ -149,10 +149,16 @@ protected abstract <T extends RESTResponse> T execute(
Consumer<ErrorResponse> errorHandler,
Consumer<Map<String, String>> responseHeaders);
- protected abstract <T extends RESTResponse> T execute(
+ protected <T extends RESTResponse> T execute(
Review Comment:
Will this actually stop a user from being broken on upgrade? If you extend
this class and execute is called without the parserContext it still breaks but
now you don't know that until runtime?
I may misunderstand the full range of possibilities here, but isn't the
internal Iceberg SDK passing through the ParserContext here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
