kevinjqliu commented on code in PR #1449:
URL: https://github.com/apache/iceberg-rust/pull/1449#discussion_r2162430124
##########
.github/workflows/publish.yml:
##########
@@ -20,7 +20,10 @@ name: Publish
on:
push:
tags:
- - "*"
+ # Trigger this workflow when tag follows the versioning format:
v<major>.<minor>.<patch> OR v<major>.<minor>.<patch>-rc.<release_candidate>
+ # Example valid tags: v0.4.0, v0.4.0-rc.1
+ - "v[0-9]+.[0-9]+.[0-9]+"
+ - "v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+"
Review Comment:
fun fact! the `on.push.tags` syntax here doesnt support regex, its a "filter
pattern"
from
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore,
```
The branches, branches-ignore, tags, and tags-ignore keywords accept glob
patterns that use characters like *, **, +, ?, ! and others to match more than
one branch or tag name. If a name contains any of these characters and you want
a literal match, you need to escape each of these special characters with \.
For more information about glob patterns, see the [Workflow syntax for GitHub
Actions](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet).
```
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
