singhpk234 commented on code in PR #13371:
URL: https://github.com/apache/iceberg/pull/13371#discussion_r2162037598


##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -266,6 +266,11 @@ public void commit(WriterCommitMessage[] messages) {
       }
     }
 
+    @Override
+    public String toString() {
+      return String.format("IcebergDeltaWrite(table=%s)", table);

Review Comment:
   - May be rename this to IcebergPositionDeltaWrite ?
   - how about including info like table current-snapshot-id as the table to 
string is just gonna do table name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to