singhpk234 commented on code in PR #13327:
URL: https://github.com/apache/iceberg/pull/13327#discussion_r2161879133
##########
core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFilePlanner.java:
##########
@@ -291,7 +306,9 @@ private StructLikeMap<List<List<FileScanTask>>>
planFileGroups() {
scan = scan.useSnapshot(snapshotId);
}
- CloseableIterable<FileScanTask> fileScanTasks = scan.planFiles();
+ CloseableIterable<FileScanTask> fileScanTasks =
+ CloseableIterable.filter(
+ scan.planFiles(), fileScanTask ->
fileFilter.test(fileScanTask.file()));
Review Comment:
I agree :), what I meant is reject the whole FileScanTask if it has deletes
which refers to remote deletes ?
currently we are rejecting the whole fileScanTask if the datafile is remote
right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
