yingcai-cy commented on code in PR #120:
URL: https://github.com/apache/iceberg-cpp/pull/120#discussion_r2161123753
##########
src/iceberg/expression/expression.h:
##########
@@ -67,8 +66,8 @@ class ICEBERG_EXPORT Expression {
virtual Operation op() const = 0;
/// \brief Returns the negation of this expression, equivalent to not(this).
- virtual Result<std::shared_ptr<Expression>> Negate() const {
- return InvalidExpression("Expression cannot be negated");
+ virtual std::shared_ptr<Expression> Negate() const {
+ throw IcebergError("Expression cannot be negated");
Review Comment:
It’s been a couple of days, let me recall. I believe the reason is that all
expression implementations have a corresponding Negate form, so none of them
would return incorrect results in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
