cmcarthur commented on PR #1455: URL: https://github.com/apache/iceberg-rust/pull/1455#issuecomment-2993589198
@liurenjie1024 thanks for the feedback! > This pr is too large to review. agreed, it is large, I will break it into at least two smaller PRs > I don't think it's a good idea to put procedure into core library. You could try to extend datafusion to do this I hear you, and it makes sense to me to move this procedure out of the core library. But, do you mean that this procedure fits in this repo, but belongs in a different crate? Or that it doesn’t fit this repository? Implementing this in datafusion (say, as a UDF) does make sense, but I don’t think it should be the only way to call this. This procedure should exist with public rust apis for integration into systems that don’t depend on datafusion. How should I proceed? I could add a new crate in this repository, or implement the procedure in a separate repository. Open to your recommendations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
