Fokko commented on code in PR #1859:
URL: https://github.com/apache/iceberg-python/pull/1859#discussion_r2159040868
##########
pyiceberg/io/pyarrow.py:
##########
@@ -626,7 +626,7 @@ def field(self, field: NestedField, field_result:
pa.DataType) -> pa.Field:
def list(self, list_type: ListType, element_result: pa.DataType) ->
pa.DataType:
element_field = self.field(list_type.element_field, element_result)
- return pa.large_list(value_type=element_field)
+ return pa.list_(value_type=element_field)
Review Comment:
Sorry, I missed this one. I don't think the `list` and `large_list` are the
problem, but `string` and `large_string`. It is possible to have a buffer that
contains more than 2GB of strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
