zhongyujiang opened a new pull request, #2128:
URL: https://github.com/apache/iceberg-python/pull/2128

   <!--
   Thanks for opening a pull request!
   -->
   
   <!-- In the case this PR will resolve an issue, please replace 
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
   <!-- Closes #${GITHUB_ISSUE_ID} -->
   
   # Rationale for this change
   The return type of the decompress method in `ZStandardCodec` should be 
`bytes`, but it currently returns a `bytearray`, which causes an exception when 
reading Avro files compressed with zstd.
   
   ```text
   def new_decoder(b: bytes) -> BinaryDecoder:
           try:
               from pyiceberg.avro.decoder_fast import CythonBinaryDecoder
   
   >           return CythonBinaryDecoder(b)
   E           TypeError: Argument 'input_contents' has incorrect type 
(expected bytes, got bytearray)
   ```
   
   # Are these changes tested?
   Yes,  `test_write_manifest`
   
   # Are there any user-facing changes?
   No.
   <!-- In the case of user-facing changes, please add the changelog label. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to