ajantha-bhat commented on code in PR #13329:
URL: https://github.com/apache/iceberg/pull/13329#discussion_r2158224710
##########
core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java:
##########
@@ -280,6 +273,8 @@ private static Collection<PartitionStats>
computeAndMergeStatsIncremental(
oldStats.forEach(
partitionStats ->
statsMap.put(partitionStats.specId(),
partitionStats.partition(), partitionStats));
+ } catch (IllegalArgumentException | IllegalStateException exception) {
Review Comment:
I think I didn't clearly get what you mean. Here `readPartitionStatsFile`
will not throw the exception. It always return the lazy iterable. Only the
caller who access items from this iterable will get the exception. Accessing
the iterable in `readPartitionStatsFile` will void the laziness. Which is not
good.
Are you suggesting to provide a new public API wrapper just to catch the
exception and throw `InvalidStatsFileException`? I feel it is redundant. Lets
see what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
