singhpk234 commented on code in PR #12988:
URL: https://github.com/apache/iceberg/pull/12988#discussion_r2158110714


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##########
@@ -387,7 +387,7 @@ public Offset latestOffset(Offset startOffset, ReadLimit 
limit) {
 
     boolean shouldContinueReading = true;
     int curFilesAdded = 0;
-    int curRecordCount = 0;
+    long curRecordCount = 0;

Review Comment:
   Ack, i just changed it to long as row count of a file is long and IJ as 
complaining ! 
   totally agree if we were to actually have a file of this big size we might 
have trouble.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to