huaxingao commented on code in PR #13290: URL: https://github.com/apache/iceberg/pull/13290#discussion_r2155780911
########## arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedValuesReader.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.arrow.vectorized.parquet; + +import org.apache.arrow.vector.FieldVector; +import org.apache.parquet.bytes.ByteBufferInputStream; +import org.apache.parquet.io.api.Binary; + +/** Interface for value decoding that supports vectorized (aka batched) decoding. */ +interface VectorizedValuesReader { + boolean readBoolean(); + + byte readByte(); + + short readShort(); + + int readInteger(); + + long readLong(); + + float readFloat(); + + double readDouble(); + + Binary readBinary(int len); + + /* + * Reads `total` values into `vec` start at `vec[rowId]` + */ Review Comment: nit: Shall we add Javadoc to all the methods for consistency? Spark usually uses block comments for similar APIs, but in those cases, the methods are grouped without blank lines. Since these are separated, it feels more like they’re meant to be documented individually. Not sure what the typical style is in Iceberg though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
